feat(team): support wide logos & team description#40
Merged
Conversation
- add teamDescription portable text (GROQ, types, PortableText on team page) - render optional 600×300 logos at 10rem height via teamLogoUrl/hasTeamLogo - keep projects section inside narrow container with compact cards - extend cms-integration Playwright tests for team detail layout - document optional logo in Sanity studio; fix teamDescription validation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- fix failed test
- fix teamDescription validation to count characters, not blocks - remove duplicate nested .team-description wrapper and empty class attr - extract hasSanityImage generic guard to client.ts - DRY portableTextPlainLength into shared studio utility - replace unsupported max-width: stretch with 100% - add _id path test coverage for team logo guard
ShugKnight24
approved these changes
May 16, 2026
ShugKnight24
left a comment
ShugKnight24
left a comment
Contributor
There was a problem hiding this comment.
Good PR
saw some things to address so I took care of them. heading offline for a bit, will follow up later
Aiming to test the admin more robustly prior to tomorrow. aiming to be at the event later tonight depending how day goes. if I get there, ill block off time to work on that
will keep you updated @shrinkray
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to improve the appearance of the team area.
This allows for a large logo area, if available and gives the team an ability to call out their college and give some thoughts to the formed group or name. I set a 1000 char limit which should be more than enough.
solves #39